Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Expose the startup timestamp to Prometheus #2233

Closed
wants to merge 3 commits into from

Conversation

paulhauner
Copy link
Member

Issue Addressed

Resolves #1788

Proposed Changes

As per #1788, expose the time at which the process started via the process_start_time_seconds Prometheus metric. This will help users track uptime.

Additional Info

NA

@paulhauner paulhauner added ready-for-review The code is ready for review low-hanging-fruit Easy to resolve, get it before someone else does! labels Mar 1, 2021
@paulhauner paulhauner requested a review from pawanjay176 March 1, 2021 01:19
Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@paulhauner
Copy link
Member Author

bors r+

@paulhauner paulhauner added ready-for-merge This PR is ready to merge. and removed low-hanging-fruit Easy to resolve, get it before someone else does! ready-for-review The code is ready for review labels Mar 2, 2021
bors bot pushed a commit that referenced this pull request Mar 2, 2021
## Issue Addressed

Resolves #1788

## Proposed Changes

As per #1788, expose the time at which the process started via the `process_start_time_seconds` Prometheus metric. This will help users track uptime.

## Additional Info

NA
@bors
Copy link

bors bot commented Mar 2, 2021

Build failed (retrying...):

@paulhauner
Copy link
Member Author

bors r-

@bors
Copy link

bors bot commented Mar 2, 2021

Canceled.

@paulhauner
Copy link
Member Author

bors r+

bors bot pushed a commit that referenced this pull request Mar 2, 2021
## Issue Addressed

Resolves #1788

## Proposed Changes

As per #1788, expose the time at which the process started via the `process_start_time_seconds` Prometheus metric. This will help users track uptime.

## Additional Info

NA
@bors
Copy link

bors bot commented Mar 2, 2021

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Mar 2, 2021
## Issue Addressed

Resolves #1788

## Proposed Changes

As per #1788, expose the time at which the process started via the `process_start_time_seconds` Prometheus metric. This will help users track uptime.

## Additional Info

NA
@bors
Copy link

bors bot commented Mar 2, 2021

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Mar 2, 2021
## Issue Addressed

Resolves #1788

## Proposed Changes

As per #1788, expose the time at which the process started via the `process_start_time_seconds` Prometheus metric. This will help users track uptime.

## Additional Info

NA
@bors
Copy link

bors bot commented Mar 2, 2021

Build failed:

@michaelsproul
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Mar 2, 2021
## Issue Addressed

Resolves #1788

## Proposed Changes

As per #1788, expose the time at which the process started via the `process_start_time_seconds` Prometheus metric. This will help users track uptime.

## Additional Info

NA
@michaelsproul
Copy link
Member

Chose the wrong bisection bors!

bors r-

@bors
Copy link

bors bot commented Mar 2, 2021

Canceled.

@michaelsproul
Copy link
Member

Will put this in the next merge batch, as it conflicted with #2239

@michaelsproul
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Mar 2, 2021
## Issue Addressed

Resolves #1788

## Proposed Changes

As per #1788, expose the time at which the process started via the `process_start_time_seconds` Prometheus metric. This will help users track uptime.

## Additional Info

NA

Co-authored-by: Michael Sproul <[email protected]>
@bors bors bot changed the title Expose the startup timestamp to Prometheus [Merged by Bors] - Expose the startup timestamp to Prometheus Mar 2, 2021
@bors bors bot closed this Mar 2, 2021
@michaelsproul michaelsproul deleted the starttime branch March 3, 2021 00:00
michaelsproul added a commit that referenced this pull request Mar 10, 2021
## Issue Addressed

Resolves #1788

## Proposed Changes

As per #1788, expose the time at which the process started via the `process_start_time_seconds` Prometheus metric. This will help users track uptime.

## Additional Info

NA

Co-authored-by: Michael Sproul <[email protected]>
michaelsproul added a commit that referenced this pull request Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge This PR is ready to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants