Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Automated release Github upload fix #2192

Closed
wants to merge 4 commits into from

Conversation

realbigsean
Copy link
Member

Issue Addressed

Our v1.1.0 automated release failed to upload to Github. The hub command failed with a 403, which seems like this issue: mislav/hub#2149

Proposed Changes

The suggested fix in that issue is to set the $GITHUB_USER environment variable. I can't really test this because this hasn't been failing on my fork, but seems low risk

@realbigsean
Copy link
Member Author

looks like rust 1.50.0 just dropped 🎤

@realbigsean realbigsean added low-hanging-fruit Easy to resolve, get it before someone else does! ready-for-review The code is ready for review and removed ready-for-review The code is ready for review labels Feb 12, 2021
Copy link
Member

@paulhauner paulhauner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try it out!

bors r+

@paulhauner paulhauner added ready-for-merge This PR is ready to merge. and removed low-hanging-fruit Easy to resolve, get it before someone else does! labels Feb 15, 2021
bors bot pushed a commit that referenced this pull request Feb 15, 2021
## Issue Addressed

Our v1.1.0 automated release failed to upload to Github. The `hub` command failed with a `403`, which seems like this issue: mislav/hub#2149
 
## Proposed Changes

The suggested fix in that issue is to set the `$GITHUB_USER` environment variable. I can't really test this because this hasn't been failing on my fork, but seems low risk



Co-authored-by: realbigsean <[email protected]>
Co-authored-by: Paul Hauner <[email protected]>
@bors
Copy link

bors bot commented Feb 15, 2021

Build failed (retrying...):

@paulhauner
Copy link
Member

bors retry

@bors
Copy link

bors bot commented Feb 15, 2021

Already running a review

bors bot pushed a commit that referenced this pull request Feb 15, 2021
## Issue Addressed

Our v1.1.0 automated release failed to upload to Github. The `hub` command failed with a `403`, which seems like this issue: mislav/hub#2149
 
## Proposed Changes

The suggested fix in that issue is to set the `$GITHUB_USER` environment variable. I can't really test this because this hasn't been failing on my fork, but seems low risk



Co-authored-by: realbigsean <[email protected]>
Co-authored-by: Paul Hauner <[email protected]>
@bors bors bot changed the title Automated release Github upload fix [Merged by Bors] - Automated release Github upload fix Feb 15, 2021
@bors bors bot closed this Feb 15, 2021
@realbigsean realbigsean deleted the automated-release-fix branch November 21, 2023 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge This PR is ready to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants