Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Add a GitHub Action to cancel previous runs #2180

Closed
wants to merge 2 commits into from

Conversation

ackintosh
Copy link
Member

@ackintosh ackintosh commented Jan 28, 2021

Issue Addressed

It takes over 20 minutes to run the GitHub Workflow for lighthouse. It would be time-saving to cancel previous runs.

Proposed Changes

Added styfle/cancel-workflow-action to our workflow. I've configured the action according to Advanced settings.

Copy link
Member

@paulhauner paulhauner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome, thank you!

I made one little suggestion, I haven't tested it though :)

runs-on: ubuntu-latest
timeout-minutes: 3
steps:
- uses: styfle/[email protected]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- uses: styfle/cancel-workflow-action@0.7.0
- uses: styfle/cancel-workflow-action@514c783

This is probably being paranoid, but this protects us from the maintainer swapping the 0.7.0 tag to something malicious that steals our secrets.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah💡 It makes sense!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested the suggestion in my sandbox repo and confirmed it works fine. 😃

https://github.com/ackintosh/sandbox/blob/master/.github/workflows/cancel.yaml#L15

@paulhauner paulhauner added the waiting-on-author The reviewer has suggested changes and awaits thier implementation. label Feb 9, 2021
Copy link
Member

@paulhauner paulhauner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ackintosh, much appreciated! 🚀

bors r+

@paulhauner paulhauner added ready-for-merge This PR is ready to merge. and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Feb 15, 2021
bors bot pushed a commit that referenced this pull request Feb 15, 2021
## Issue Addressed

It takes over 20 minutes to run the GitHub Workflow for lighthouse. It would be time-saving to cancel previous runs. 

## Proposed Changes

Added [styfle/cancel-workflow-action](https://github.com/styfle/cancel-workflow-action) to our workflow. I've configured the action according to [Advanced settings](https://github.com/styfle/cancel-workflow-action#advanced).
@bors
Copy link

bors bot commented Feb 15, 2021

Build failed (retrying...):

@paulhauner
Copy link
Member

bors retry

@bors
Copy link

bors bot commented Feb 15, 2021

Already running a review

@paulhauner
Copy link
Member

bors r-

@bors
Copy link

bors bot commented Feb 15, 2021

Canceled.

@paulhauner
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Feb 15, 2021
## Issue Addressed

It takes over 20 minutes to run the GitHub Workflow for lighthouse. It would be time-saving to cancel previous runs. 

## Proposed Changes

Added [styfle/cancel-workflow-action](https://github.com/styfle/cancel-workflow-action) to our workflow. I've configured the action according to [Advanced settings](https://github.com/styfle/cancel-workflow-action#advanced).
@bors bors bot changed the title Add a GitHub Action to cancel previous runs [Merged by Bors] - Add a GitHub Action to cancel previous runs Feb 15, 2021
@bors bors bot closed this Feb 15, 2021
@ackintosh ackintosh deleted the cancel-workflow-action branch February 15, 2021 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge This PR is ready to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants