-
Notifications
You must be signed in to change notification settings - Fork 809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Add a GitHub Action to cancel previous runs #2180
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome, thank you!
I made one little suggestion, I haven't tested it though :)
runs-on: ubuntu-latest | ||
timeout-minutes: 3 | ||
steps: | ||
- uses: styfle/[email protected] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- uses: styfle/cancel-workflow-action@0.7.0 | |
- uses: styfle/cancel-workflow-action@514c783 |
This is probably being paranoid, but this protects us from the maintainer swapping the 0.7.0
tag to something malicious that steals our secrets.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah💡 It makes sense!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tested the suggestion in my sandbox repo and confirmed it works fine. 😃
https://github.com/ackintosh/sandbox/blob/master/.github/workflows/cancel.yaml#L15
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @ackintosh, much appreciated! 🚀
bors r+
## Issue Addressed It takes over 20 minutes to run the GitHub Workflow for lighthouse. It would be time-saving to cancel previous runs. ## Proposed Changes Added [styfle/cancel-workflow-action](https://github.com/styfle/cancel-workflow-action) to our workflow. I've configured the action according to [Advanced settings](https://github.com/styfle/cancel-workflow-action#advanced).
Build failed (retrying...): |
bors retry |
Already running a review |
bors r- |
Canceled. |
bors r+ |
## Issue Addressed It takes over 20 minutes to run the GitHub Workflow for lighthouse. It would be time-saving to cancel previous runs. ## Proposed Changes Added [styfle/cancel-workflow-action](https://github.com/styfle/cancel-workflow-action) to our workflow. I've configured the action according to [Advanced settings](https://github.com/styfle/cancel-workflow-action#advanced).
Pull request successfully merged into unstable. Build succeeded: |
Issue Addressed
It takes over 20 minutes to run the GitHub Workflow for lighthouse. It would be time-saving to cancel previous runs.
Proposed Changes
Added styfle/cancel-workflow-action to our workflow. I've configured the action according to Advanced settings.