-
Notifications
You must be signed in to change notification settings - Fork 809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Modify proto array loop #2154
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of minor nits, but looks good otherwise!
This comment is a bit out of date now:
// If the node has a parent, try to update its best-child and best-descendant. |
let node = self | ||
.nodes | ||
.get_mut(node_index) | ||
.ok_or_else(|| Error::InvalidNodeIndex(node_index))?; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could use ok_or
instead
bors r+ |
## Issue Addressed NA ## Proposed Changes As discussed with @protolambda, add an additional loop inside proto_array to ensure weights are coherent. ## Additional Info NA
Pull request successfully merged into unstable. Build succeeded: |
Issue Addressed
NA
Proposed Changes
As discussed with @protolambda, add an additional loop inside proto_array to ensure weights are coherent.
Additional Info
NA