Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Modify proto array loop #2154

Closed
wants to merge 5 commits into from
Closed

Conversation

paulhauner
Copy link
Member

Issue Addressed

NA

Proposed Changes

As discussed with @protolambda, add an additional loop inside proto_array to ensure weights are coherent.

Additional Info

NA

@paulhauner paulhauner added the ready-for-review The code is ready for review label Jan 13, 2021
@paulhauner paulhauner changed the base branch from stable to unstable January 13, 2021 03:07
@paulhauner paulhauner added the low-hanging-fruit Easy to resolve, get it before someone else does! label Jan 13, 2021
Copy link
Member

@realbigsean realbigsean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of minor nits, but looks good otherwise!

This comment is a bit out of date now:

// If the node has a parent, try to update its best-child and best-descendant.

let node = self
.nodes
.get_mut(node_index)
.ok_or_else(|| Error::InvalidNodeIndex(node_index))?;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could use ok_or instead

@paulhauner
Copy link
Member Author

bors r+

@paulhauner paulhauner added ready-for-merge This PR is ready to merge. and removed low-hanging-fruit Easy to resolve, get it before someone else does! ready-for-review The code is ready for review labels Jan 19, 2021
@paulhauner paulhauner self-assigned this Jan 19, 2021
bors bot pushed a commit that referenced this pull request Jan 19, 2021
## Issue Addressed

NA

## Proposed Changes

As discussed with @protolambda, add an additional loop inside proto_array to ensure weights are coherent.

## Additional Info

NA
@bors bors bot changed the title Modify proto array loop [Merged by Bors] - Modify proto array loop Jan 19, 2021
@bors bors bot closed this Jan 19, 2021
@paulhauner paulhauner deleted the fc-double-iter branch January 20, 2021 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge This PR is ready to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants