Add new PlainTextString type to ensure all passwords are valid UTF-8 #2070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
film42
force-pushed
the
gt/utf8_pass_v2
branch
from
cf428fd to
72210c6
Compare
|
would you mind changing the target branch from |
Done :) |
|
Thanks @paulhauner ! |
bors bot
pushed a commit
that referenced
this pull request
Mar 14, 2021
## Issue Addressed #2224 ## Proposed Changes Add a `--password-file` option to the `lighthouse account validator import` command. The flag requires `--reuse-password` and will copy the password over to the `validator_definitions.yml` file. I used #2070 as a guide for validating the password as UTF-8 and stripping newlines. ## Additional Info Co-authored-by: realbigsean <[email protected]>
bors bot
pushed a commit
that referenced
this pull request
Mar 17, 2021
## Issue Addressed #2224 ## Proposed Changes Add a `--password-file` option to the `lighthouse account validator import` command. The flag requires `--reuse-password` and will copy the password over to the `validator_definitions.yml` file. I used #2070 as a guide for validating the password as UTF-8 and stripping newlines. ## Additional Info Co-authored-by: realbigsean <[email protected]>
|
I'm going to close this since it's been open a long time. My apologies for not getting to a review. This PR will remain and the issue will be tracked at #1205. Please feel free to pick this up again, if you'd like! |
|
Thanks for all you do, Paul! <3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Issue #1205
Feedback from PR #1217
This supersedes my previous PR #1770 .
Proposed Changes
fs::read_to_stringto enforce utf8 when dealing with reading passwords from files.PlainText(Vec<u8>)to becomePlainText(String). This was not possible because I found existing (and valid) instances wherePlainTextcontained invalid utf8. I do like the idea of aPlainTextStringthough, so this PR introduces a new and more specific type,PlainTextString(String). It might be a little clumsy to have two differentPlainTexttypes, but I think it makes sense.&[u8], and I switched some (but not all) to use the newPlainTextString. Happy to remove what I added if you would like these changed in a followup PR.PlainTextStringtype uses anunsafeblock to makeas_mut_byteswork. This will panic if the caller of this method changes the internal bytes to become invalid utf8. Any ideas around making this more sound?Additional Info
I mentioned this in the other PR but I'm relatively new to rust, so don't hesitate to add lots of feedback!