Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Drop discovery log to trace #2007

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - Drop discovery log to trace #2007

wants to merge 2 commits into from

Conversation

paulhauner
Copy link
Member

Issue Addressed

NA

Proposed Changes

This was causing:

Nov 28 21:56:08.154 ERRO slog-async: logger dropped messages due to channel overflow, count: 44, service: libp2p

Additional Info

NA

@paulhauner paulhauner added the ready-for-review The code is ready for review label Nov 29, 2020
@paulhauner paulhauner changed the base branch from stable to unstable November 29, 2020 02:50
AgeManning
AgeManning approved these changes Nov 29, 2020
View reviewed changes
Copy link
Member

@AgeManning AgeManning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AgeManning
Copy link
Member

bors r+

1 similar comment
@paulhauner
Copy link
Member Author

bors r+

@bors
Copy link

bors bot commented Nov 29, 2020

Already running a review

@paulhauner paulhauner added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Nov 29, 2020
bors bot pushed a commit that referenced this pull request Nov 29, 2020
@paulhauner
Drop discovery log to trace (#2007)
85e6924 
## Issue Addressed

NA

## Proposed Changes

This was causing:

```
Nov 28 21:56:08.154 ERRO slog-async: logger dropped messages due to channel overflow, count: 44, service: libp2p
```

## Additional Info

NA
@bors
Copy link

bors bot commented Nov 29, 2020

Pull request successfully merged into unstable.

Build succeeded:

@bors bors bot changed the title Drop discovery log to trace [Merged by Bors] - Drop discovery log to trace Nov 29, 2020
@bors bors bot closed this Nov 29, 2020
@paulhauner paulhauner deleted the drop-disc-log branch January 20, 2021 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AgeManning AgeManning AgeManning approved these changes

Assignees
No one assigned
Labels
ready-for-merge This PR is ready to merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulhauner @AgeManning