Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Avoid some allocations in BlockSignatureVerifier #1922

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Avoid some allocations in BlockSignatureVerifier #1922

wants to merge 1 commit into from

Conversation

paulhauner
Copy link
Member

Issue Addressed

NA

Proposed Changes

Avoids growing/allocating some Vecs.

Additional Info

NA

@paulhauner paulhauner added the ready-for-review The code is ready for review label Nov 17, 2020
michaelsproul
michaelsproul approved these changes Nov 17, 2020
View reviewed changes
Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another nice saving!

@paulhauner
Copy link
Member Author

Thanks!

bors r+

bors bot pushed a commit that referenced this pull request Nov 17, 2020
@paulhauner
Avoid some allocations in BlockSignatureVerifier (#1922)
ecff880 
## Issue Addressed

NA

## Proposed Changes

Avoids growing/allocating some `Vec`s.

## Additional Info

NA
@paulhauner paulhauner added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Nov 17, 2020
@bors
Copy link

bors bot commented Nov 17, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title Avoid some allocations in BlockSignatureVerifier [Merged by Bors] - Avoid some allocations in BlockSignatureVerifier Nov 17, 2020
@bors bors bot closed this Nov 17, 2020
@paulhauner paulhauner deleted the sig-ver-alloc branch March 17, 2021 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelsproul michaelsproul michaelsproul approved these changes

Assignees
No one assigned
Labels
ready-for-merge This PR is ready to merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulhauner @michaelsproul