Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Tweak head syncing #1845

Closed

Conversation

divagant-martian
Copy link
Collaborator

Issue Addressed

Fixes head syncing

Proposed Changes

  • Get back to statusing peers after removing chain segments and making the peer manager deal with status according to the Sync status, preventing an old known deadlock
  • Also a bug where a chain would get removed if the optimistic batch succeeds being empty

Additional Info

Tested on Medalla and looking good

Copy link
Member

@AgeManning AgeManning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@AgeManning
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Nov 1, 2020
## Issue Addressed

Fixes head syncing

## Proposed Changes

- Get back to statusing peers after removing chain segments and making the peer manager deal with status according to the Sync status, preventing an old known deadlock
- Also a bug where a chain would get removed if the optimistic batch succeeds being empty

## Additional Info

Tested on Medalla and looking good
@bors bors bot changed the title Tweak head syncing [Merged by Bors] - Tweak head syncing Nov 2, 2020
@bors bors bot closed this Nov 2, 2020
@divagant-martian divagant-martian deleted the tweak-head-syncing branch January 4, 2021 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants