[Merged by Bors] - Only run http_api tests in release #1827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulhauner
added
ready-for-review
|
@realbigsean do you mind running your eyes past this please? :) |
|
bors r+ |
paulhauner
added
ready-for-merge
|
Hmm.. seems bors is stuck. bors retry |
bors bot
pushed a commit
that referenced
this pull request
Oct 29, 2020
## Issue Addressed NA ## Proposed Changes As raised by @hermanjunge in a DM, the `http_api` tests have been observed taking 100+ minutes on debug. This PR: - Moves the `http_api` tests to only run in release. - Groups some `http_api` tests to reduce test-setup overhead. ## Additional Info NA
|
bors r- |
|
Canceled. |
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Oct 29, 2020
## Issue Addressed NA ## Proposed Changes As raised by @hermanjunge in a DM, the `http_api` tests have been observed taking 100+ minutes on debug. This PR: - Moves the `http_api` tests to only run in release. - Groups some `http_api` tests to reduce test-setup overhead. ## Additional Info NA
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
NA
Proposed Changes
As raised by @hermanjunge in a DM, the
http_apitests have been observed taking 100+ minutes on debug. This PR:http_apitests to only run in release.http_apitests to reduce test-setup overhead.Additional Info
NA