[Merged by Bors] - Add cli option for voluntary exits #1781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested this out on a few of my medalla validators and it works as expected. |
paulhauner
requested changes
Oct 22, 2020
paulhauner
added
waiting-on-author
pawanjay176
force-pushed
the
voluntary-exits
branch
from
fbf0bf5 to
17fef8f
Compare
|
@paulhauner Addressed your comments and added a I'm not sure how to do end to end testing for this. I think it would require us to have some mock beacon client implementation. Is there any other simpler way ? |
pawanjay176
added
ready-for-review
paulhauner
requested changes
Oct 29, 2020
paulhauner
added
waiting-on-author
pawanjay176
force-pushed
the
voluntary-exits
branch
2 times, most recently
from
dde00ec to
7b61d4e
Compare
pawanjay176
force-pushed
the
voluntary-exits
branch
from
7b61d4e to
6423b08
Compare
pawanjay176
added
ready-for-review
paulhauner
added
ready-for-merge
bors bot
pushed a commit
that referenced
this pull request
Oct 29, 2020
## Issue Addressed Resolve #1652 ## Proposed Changes Adds a cli option for voluntary exits. The flow is similar to prysm's where after entering the password for the validator keystore (or load password from `secrets` if present) the user is given multiple warnings about the operation being irreversible, then redirected to the docs webpage(not added yet) which explains what a voluntary exit is and the consequences of exiting and then prompted to enter a phrase from the docs webpage as a final confirmation. Example usage ``` $ lighthouse --testnet zinken account validator exit --validator <validator-pubkey> --beacon-node http://localhost:5052 Running account manager for zinken testnet validator-dir path: "..." Enter the keystore password: for validator in ... Password is correct Publishing a voluntary exit for validator: ... WARNING: This is an irreversible operation WARNING: Withdrawing staked eth will not be possible until Eth1/Eth2 merge Please visit [website] to make sure you understand the implications of a voluntary exit. Enter the phrase from the above URL to confirm the voluntary exit: Exit my validator Published voluntary exit for validator ... ``` ## Additional info Not sure if we should have batch exits (`--validator all`) option for exiting all the validators in the `validators` directory. I'm slightly leaning towards having only single exits but don't have a strong preference.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Resolve #1652
Proposed Changes
Adds a cli option for voluntary exits. The flow is similar to prysm's where after entering the password for the validator keystore (or load password from
secretsif present) the user is given multiple warnings about the operation being irreversible, then redirected to the docs webpage(not added yet) which explains what a voluntary exit is and the consequences of exiting and then prompted to enter a phrase from the docs webpage as a final confirmation.Example usage
Additional info
Not sure if we should have batch exits (
--validator all) option for exiting all the validators in thevalidatorsdirectory. I'm slightly leaning towards having only single exits but don't have a strong preference.