[Merged by Bors] - Fixed cross-compiling by replacing wget with curl #1759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like the default docker image used by cross doesn't have wget installed. This causes builds to fail. This can be fixed by switching to curl.
michaelsproul
approved these changes
Oct 11, 2020
bors bot
pushed a commit
that referenced
this pull request
Oct 11, 2020
It looks like the default docker image used by cross doesn't have wget installed. This causes builds to fail. This can be fixed by switching to curl. ## Issue Addressed cross-compiling was broken (at least for build-aarch64) ## Proposed Changes swap wget for curl
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like the default docker image used by cross doesn't have
wget installed. This causes builds to fail. This can be fixed by
switching to curl.
Issue Addressed
cross-compiling was broken (at least for build-aarch64)
Proposed Changes
swap wget for curl