[Merged by Bors] - Strict slashing protection by default #1750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelsproul
added
ready-for-review
|
Ready for review. Now includes a tasty fail-fast feature that causes the VC to bail out early if the slashing protection database is misconfigured. 🤞 that all the tests pass |
paulhauner
approved these changes
Oct 9, 2020
| @@ -32,8 +32,8 @@ pub struct Config { | |||
| pub delete_lockfiles: bool, | |||
| /// If true, don't scan the validators dir for new keystores. | |||
| pub disable_auto_discover: bool, | |||
| /// If true, don't re-register existing validators in definitions.yml for slashing protection. | |||
| pub strict_slashing_protection: bool, | |||
| /// If true, re-register existing validators in definitions.yml for slashing protection. | |||
There was a problem hiding this comment.
Does this also register validators that didn't exist originally? Just checking this is worded accurately.
There was a problem hiding this comment.
It's a little bit clunky, but I think it will register all validators from the validator definitions YAML, I'll earmark it for improvement in a subsequent PR, seeing as we're tight for time
|
Batch merging with #1743 bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Oct 9, 2020
## Proposed Changes Replace `--strict-slashing-protection` by `--init-slashing-protection` and remove mentions of `--auto-register`
|
Pull request successfully merged into v0.3.0-staging. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Replace
--strict-slashing-protectionby--init-slashing-protectionand remove mentions of--auto-register