Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subscribing to attestation subnets for aggregating does not work correctly #6681

Closed
povi opened this issue Dec 11, 2024 · 0 comments
Closed
Labels
bug Something isn't working v6.0.1 Bugfix for v6.0.0

Comments

@povi
Copy link
Contributor

povi commented Dec 11, 2024

Description

If [/eth/v1/validator/beacon_committee_subscriptions](https://ethereum.github.io/beacon-APIs/#/Validator/prepareBeaconCommitteeSubnet) request contains multiple aggregator subscriptions to the same attestation subnet at different slots, it respects only the last subscription per subnet:

E.g. if there request contains these subscriptions:

[
  {
    "validator_index": "1",
    "committee_index": "1",
    "committees_at_slot": "2",
    "slot": "2",
    "is_aggregator": true
  },
  {
    "validator_index": "2",
    "committee_index": "2",
    "committees_at_slot": "2",
    "slot": "7",
    "is_aggregator": true
  },
  {
    "validator_index": "3",
    "committee_index": "1",
    "committees_at_slot": "2",
    "slot": "12",
    "is_aggregator": true
  }
]

it will only subscribe to attestation subnets for aggregating at slots 7 and 12, ignoring slot 2.

@povi povi changed the title Subscribing to attestation subnets does not work correctly Subscribing to attestation subnets for aggregating does not work correctly Dec 11, 2024
povi added a commit to povi/lighthouse that referenced this issue Dec 11, 2024
* Prevent scheduled subnet subscriptions from being overwritten by other subscriptions from same subnet with additional scoping by slot
michaelsproul pushed a commit to povi/lighthouse that referenced this issue Dec 11, 2024
* Prevent scheduled subnet subscriptions from being overwritten by other subscriptions from same subnet with additional scoping by slot
michaelsproul pushed a commit to povi/lighthouse that referenced this issue Dec 11, 2024
* Prevent scheduled subnet subscriptions from being overwritten by other subscriptions from same subnet with additional scoping by slot
@michaelsproul michaelsproul added bug Something isn't working v6.0.1 Bugfix for v6.0.0 labels Dec 11, 2024
povi added a commit to povi/lighthouse that referenced this issue Dec 12, 2024
* Prevent scheduled subnet subscriptions from being overwritten by other subscriptions from same subnet with additional scoping by slot
michaelsproul pushed a commit to povi/lighthouse that referenced this issue Dec 12, 2024
* Prevent scheduled subnet subscriptions from being overwritten by other subscriptions from same subnet with additional scoping by slot
mergify bot pushed a commit that referenced this issue Dec 12, 2024
* Fix subscribing to attestation subnets for aggregating (#6681)

* Prevent scheduled subnet subscriptions from being overwritten by other subscriptions from same subnet with additional scoping by slot
@sigp sigp deleted a comment from char23-web Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working v6.0.1 Bugfix for v6.0.0
Projects
None yet
Development

No branches or pull requests

2 participants