Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove INVALID_TERMINAL_BLOCK status and handling #3379

Closed
michaelsproul opened this issue Jul 27, 2022 · 1 comment
Closed

Remove INVALID_TERMINAL_BLOCK status and handling #3379

michaelsproul opened this issue Jul 27, 2022 · 1 comment
Assignees
@pawanjay176
Labels
bellatrix Required to support the Bellatrix Upgrade

Comments

@michaelsproul
Copy link
Member

Description

The latest spec has removed the INVALID_TERMINAL_BLOCK status. We should update Lighthouse according to the changes described here: ethereum/execution-apis#217. Our version of this status is called InvalidTerminalBlock, and grepping for it currently yields 22 results

Version

v2.4.0
@michaelsproul michaelsproul added the bellatrix Required to support the Bellatrix Upgrade label Jul 27, 2022
@pawanjay176 pawanjay176 self-assigned this Jul 28, 2022
@pawanjay176 pawanjay176 mentioned this issue Jul 28, 2022
Closed
bors bot pushed a commit that referenced this issue Aug 10, 2022
@pawanjay176
Remove INVALID_TERMINAL_BLOCK (#3385)
c259349 
## Issue Addressed

Resolves #3379 

## Proposed Changes

Remove instances of `InvalidTerminalBlock` in lighthouse and use 
`Invalid {latest_valid_hash: "0x0000000000000000000000000000000000000000000000000000000000000000"}` 
to represent that status.
@paulhauner
Copy link
Member

Resolved via #3385 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pawanjay176 pawanjay176

Labels
bellatrix Required to support the Bellatrix Upgrade
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@michaelsproul @paulhauner @pawanjay176