Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strip newline from jwt secret (or better error) #3128

Closed
lightclient opened this issue Mar 29, 2022 · 1 comment
Closed

Strip newline from jwt secret (or better error) #3128

lightclient opened this issue Mar 29, 2022 · 1 comment
Assignees
@pawanjay176

Comments

@lightclient
Copy link
Contributor

Description

When starting lighthouse with a jwt secret that ends in a new line (e.g. 0x1234..5678\n), I get the following error

CRIT Failed to start beacon node             reason: unable to start execution layer endpoints: InvalidJWTSecret("Invalid hex s
tring: OddLength")

It seems that it would be better to either i) strip this or ii) suggest the user remove the trailing newline. For additional context, go-ethereum is happy to strip the newline and carry on about it's day.

Version

unstable
@pawanjay176 pawanjay176 self-assigned this Mar 30, 2022
@pawanjay176
Copy link
Member

Thanks for the issue. I thought we already strip newlines but apparently we don't.
Will make a PR.

@pawanjay176 pawanjay176 mentioned this issue Mar 30, 2022
Closed
paulhauner pushed a commit to paulhauner/lighthouse that referenced this issue Apr 4, 2022
@pawanjay176 @paulhauner
Strip newline from jwt secrets (sigp#3132)
efe3f93 
## Issue Addressed

Resolves sigp#3128 

## Proposed Changes

Strip trailing newlines from jwt secret files.
paulhauner pushed a commit to paulhauner/lighthouse that referenced this issue May 6, 2022
@pawanjay176 @paulhauner
Strip newline from jwt secrets (sigp#3132)
c95b520 
## Issue Addressed

Resolves sigp#3128 

## Proposed Changes

Strip trailing newlines from jwt secret files.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pawanjay176 pawanjay176

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pawanjay176 @lightclient