Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/eth/v1/debug/beacon/states/genesis issues #1776

Closed
mcdee opened this issue Oct 15, 2020 · 2 comments
Closed

/eth/v1/debug/beacon/states/genesis issues #1776

mcdee opened this issue Oct 15, 2020 · 2 comments
Assignees

Comments

@mcdee
Copy link
Contributor

mcdee commented Oct 15, 2020

Running against a relatively recent master:

$ git rev-parse HEAD
e9d5bade367e4720a0ceea9d15fe994256f5ead6

Node is synced to Medalla.

Test run of /eth/v1/debug/beacon/states/genesis against the new API showed up a couple of issues.

Firstly, it returned the current state rather than the genesis state:

      "slot": "505608",

Second, the previous justified checkpoint information appears incorrect (a duplicate of the current justified checkpoint):

      "previous_justified_checkpoint": {
        "epoch": "15705",
        "root": "0x66ba71dfb29bada27c3f99e9823dac4272ff1a057814d0672353358571cb0142"
      },
      "current_justified_checkpoint": {
        "epoch": "15705",
        "root": "0x66ba71dfb29bada27c3f99e9823dac4272ff1a057814d0672353358571cb0142"
      },
@realbigsean
Copy link
Member

@mcdee Thanks for bringing these up!

I've raised a pull request to resolve the genesis state issue. I believe the issue with the previous_justified_checkpoint equaling the current_justified_checkpoint is due to the finality issues on Medalla. In this portion of the eth2 spec, the previous_justified_checkpoint is updated to the current_justified_checkpoint before checking for participation.

@mcdee
Copy link
Contributor Author

mcdee commented Oct 19, 2020

Two more items (I'll add them here because they are part of the same call): the balances and slashings arrays are returned as numbers but should be strings.

@bors bors bot closed this as completed in 628891d Oct 22, 2020
bors bot pushed a commit that referenced this issue Oct 29, 2020
…1794)

## Issue Addressed

This comment: #1776 (comment)

## Proposed Changes

- Add quoted serde utils for `FixedVector` and `VariableList`
- Had to remove the dependency that `ssz_types` has on `serde_utils` to avoid a circular dependency.

## Additional Info


Co-authored-by: realbigsean <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants