Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for tty/stdin passwords for all account flows #1437

Closed
paulhauner opened this issue Aug 3, 2020 · 2 comments
Closed

Allow for tty/stdin passwords for all account flows #1437

paulhauner opened this issue Aug 3, 2020 · 2 comments
Assignees
@realbigsean
Labels
enhancement New feature or request sept-sec-review Required for the September 1st security review UX-and-logs

Comments

@paulhauner
Copy link
Member

Description

Currently most of the lighthouse account commands (e.g., lighthouse account wallet) require that passwords are supplied via files on the filesystem. This is useful for automated deployments, however it can feel clunky for users.

Steps to resolve

Like the lighthouse account validator import and lighthouse vc commands, we should allow for users to supply passwords interactively via tty (or optionally stdin) if the --password-file (or w/e) flag is not specified.
@paulhauner paulhauner added enhancement New feature or request sept-sec-review Required for the September 1st security review labels Aug 3, 2020
@paulhauner paulhauner mentioned this issue Aug 3, 2020
Closed
8 tasks
@ghost ghost added A0 UX-and-logs labels Sep 9, 2020
@paulhauner
Copy link
Member Author

paulhauner commented Sep 9, 2020 •
edited
Loading

I believe @realbigsean will be working on this soon :)

@realbigsean realbigsean self-assigned this Sep 10, 2020
@realbigsean realbigsean mentioned this issue Sep 15, 2020
Closed
bors bot pushed a commit that referenced this issue Sep 23, 2020
@realbigsean
Interactive account passwords (#1623)
1801dd1 
## Issue Addressed

#1437

## Proposed Changes

- Make the `--wallet-password` flag optional and creates an interactive prompt if not provided.
- Make the `--wallet-name` flag optional and creates an interactive prompt if not provided.
- Add a minimum password requirement of a 12 character length.
- Update the `--stdin-passwords` flag to `--stdin-inputs` because we have non-password user inputs 

## Additional Info
@paulhauner
Copy link
Member Author

paulhauner commented Sep 25, 2020 •
edited
Loading

Resolved in #1623

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@realbigsean realbigsean

Labels
enhancement New feature or request sept-sec-review Required for the September 1st security review UX-and-logs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@realbigsean @paulhauner