Skip to content

Commit

Permalink
Allow setting web3signer version through environment (#3369)
Browse files Browse the repository at this point in the history
The goal is to make it possible to build Lighthouse without network access,
so builds can be reproducible.

This parallels the existing functionality in `common/deposit_contract/build.rs`,
which allows specifying a filename through the environment to avoid downloading
it. In this case, by specifying the version and making it available on the
filesystem, the existing logic will avoid a network download.
  • Loading branch information
philipmw committed Jul 26, 2022
1 parent 904dd62 commit cfdcc29
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 0 deletions.
3 changes: 3 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -9,3 +9,6 @@ perf.data*
/bin
genesis.ssz
/clippy.toml

# IntelliJ
/*.iml
2 changes: 2 additions & 0 deletions testing/web3signer_tests/build.rs
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@ pub async fn download_binary(dest_dir: PathBuf) {

let version = if let Some(version) = FIXED_VERSION_STRING {
version.to_string()
} else if let Ok(env_version) = env::var("LIGHTHOUSE_WEB3SIGNER_VERSION") {
env_version
} else {
// Get the latest release of the web3 signer repo.
let latest_response: Value = client
Expand Down

0 comments on commit cfdcc29

Please sign in to comment.