Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate form_label name to the UI navbar #368

Closed
signebedi opened this issue Oct 21, 2024 · 2 comments
Closed

Propagate form_label name to the UI navbar #368

signebedi opened this issue Oct 21, 2024 · 2 comments

Comments

@signebedi
Copy link
Owner

The navbar does not currently use the form_label field. It makes sense; to access it, we need to (under current logic) render the full form model / config. Instead, we might want to create a macro called get_visible_form_names() that return a key-value pair between the form config name (eg. not necessarily human readable) and the human readable form, which defaults to a title-case rendering of the form name but can be overwritten by the form_label field.

Originally posted by @signebedi in #367 (comment)

@signebedi
Copy link
Owner Author

What this issue doesn't do: it does NOT propagate the form label across the application. There are plenty of places where the default form name is being used and not being masked by its label. Eg. All the read/search pages, esp. those with datatables.

@signebedi
Copy link
Owner Author

Propagate form_label name to read/search UI pages
This needs to be extended to mask instances of the form name where we can / where it makes sense. There are some places where I imaging we will not want to use the label... It can be easily accessed in the Jinja2 as visible_form_names[form_name], which can replace references to form_name that replace the underscore with a space...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant