Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for basic query parameters (=, <, >, <=, >=) in read_all API #288

Closed
signebedi opened this issue Jun 25, 2024 · 2 comments
Closed

Add support for basic query parameters (=, <, >, <=, >=) in read_all API #288

signebedi opened this issue Jun 25, 2024 · 2 comments

Comments

@signebedi
Copy link
Owner

A query field that checks for basic values could be very useful. However, at that point, we should consider whether read_all is the right venue for this feature, or if a query_all API endpoint might be more apropos.
@signebedi signebedi mentioned this issue Jun 25, 2024
Open
signebedi added a commit that referenced this issue Jun 27, 2024
@signebedi
Added: untested support for query params in read_all API route (#288)
7a2e41a
@signebedi
Copy link
Owner Author

signebedi commented Jun 27, 2024 •
edited
Loading

We've added this, but I think some of the operators need to be tested, against various types. Datetimes especially present the greatest difficulty for comparison. Additionally, the parameter needs to be url encoded which is a hassle.

@signebedi
Copy link
Owner Author

Now that this is introduced, we should incorporate this logic into #322.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@signebedi