Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for form_display_fields in form config field params #279

Closed
signebedi opened this issue Jun 23, 2024 · 1 comment
Closed

Add support for form_display_fields in form config field params #279

signebedi opened this issue Jun 23, 2024 · 1 comment

Comments

@signebedi
Copy link
Owner

When we have a form lookup, we should enable end users to pass the following field parameter to the form config:

form_display_fields: str | List[str] | None, 

This should be a list of string fields (if the field doesn't exist, then just ignore them) to show as options instead of the (admittedly not very user friendly) document ID.

Originally posted by @signebedi in #150 (comment)

@signebedi
Copy link
Owner Author

signebedi commented Jun 24, 2024

I think instead of defaulting to None, we should default this to __metadata__document_id, which is the flattened key name for the document ID field. Then, when links_to_form is a string (see #280), we override the options parameter for that field and use these overrides instead (be aware of potential implications this may have for #169. This effectively renders the !all_submissions_<form_name> constructor (see #150) obsolete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant