Refactor Call Fabric SDK #983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8822391 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
iAmmar7
commented
Mar 14, 2024
| @@ -97,8 +105,8 @@ export class WSClient { | |||
| watchMediaPackets: false, | |||
| // watchMediaPacketsTimeout:, | |||
| nodeId: params.nodeId, | |||
| eventsWatcher: unifiedEventsWatcher, | |||
There was a problem hiding this comment.
Apart from this change, all the other changes in this file are due to the prettier format.
|
The Call Facade object is yet to be created but for now, this PR handles the Call Segments creation and stores those into an array which is accessible via BaseComponent. With this CallSegment array and the member instances stored in the InstanceMap, it's easier to pick |
jpsantosbh
reviewed
Mar 27, 2024
jpsantosbh
reviewed
Mar 27, 2024
jpsantosbh
reviewed
Mar 27, 2024
jpsantosbh
reviewed
Mar 27, 2024
jpsantosbh
reviewed
Mar 27, 2024
jpsantosbh
reviewed
Mar 27, 2024
jpsantosbh
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of change
Code snippets
In case of new feature or breaking changes, please include code snippets.