Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement catchable voice call workers saga #875

Merged
merged 2 commits into from
Sep 8, 2023
Merged

Conversation

iAmmar7
Copy link
Collaborator

@iAmmar7 iAmmar7 commented Sep 7, 2023

Description

Introduce a catchable worker saga for voice-calling APIs to minimize the error effect. If any of the child workers throws an error, the parent will not stop listening to the newer events.

Type of change

  • Internal refactoring
  • Bug fix (bugfix - non-breaking)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Code snippets

no change

@changeset-bot
Copy link

changeset-bot bot commented Sep 7, 2023

🦋 Changeset detected

Latest commit: 9146f7a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@signalwire/realtime-api Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@iAmmar7 iAmmar7 changed the title Implement catchable voice call saga Implement catchable voice call workers saga Sep 7, 2023
Copy link
Contributor

@edolix edolix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@edolix edolix merged commit a3ef96e into main Sep 8, 2023
@edolix edolix deleted the aa/catchable-voice-saga branch September 8, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants