Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for record pause and resume #863

Merged
merged 4 commits into from
Sep 8, 2023
Merged

Conversation

iAmmar7
Copy link
Collaborator

@iAmmar7 iAmmar7 commented Aug 28, 2023

Description

Allow users to pause and resume call recording.

Ref: https://github.com/signalwire/cloud-product/issues/7799

Type of change

  • Internal refactoring
  • Bug fix (bugfix - non-breaking)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Code snippets

call.on('recording.started', (recording) => {})

call.on('recording.updated', (recording) => {})

call.on('recording.ended', (recording) => {})

call.on('recording.failed', (recording) => {})

// Start the recording
const recording = await call.recordAudio({
  initialTimeout: 0,
  direction: 'both',
  terminators: '#',
})
...
await recording.pause({ behavior: "skip" }) // Optional parameters
...
await recording.resume()
...
await recording.stop()

@changeset-bot
Copy link

changeset-bot bot commented Aug 28, 2023

🦋 Changeset detected

Latest commit: c690870

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@signalwire/realtime-api Minor
@signalwire/core Minor
@signalwire/js Patch
@signalwire/web-api Patch
@signalwire/webrtc Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@iAmmar7
Copy link
Collaborator Author

iAmmar7 commented Aug 28, 2023

Testing is needed when server implementation is completed.

Ref: https://github.com/signalwire/cloud-product/issues/7033

@edolix edolix changed the title WIP: Add support for record pause and resume Add support for record pause and resume Sep 1, 2023
Copy link
Contributor

@edolix edolix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@iAmmar7 iAmmar7 force-pushed the aa/record-pause-resume branch from 0448a5e to 6de57fd Compare September 7, 2023 11:19
Copy link
Contributor

@edolix edolix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@edolix edolix merged commit fb45dce into main Sep 8, 2023
@edolix edolix deleted the aa/record-pause-resume branch September 8, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants