Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CloseEvent #858

Merged
merged 5 commits into from
Aug 15, 2023
Merged

Fix CloseEvent #858

merged 5 commits into from
Aug 15, 2023

Conversation

edolix
Copy link
Contributor

@edolix edolix commented Aug 14, 2023

Description

This PR fixes a bug on using the custom CloseEvent implementation.

Type of change

  • Internal refactoring
  • Bug fix (bugfix - non-breaking)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Code snippets

No changes required - internal bugfix

@changeset-bot
Copy link

changeset-bot bot commented Aug 14, 2023

🦋 Changeset detected

Latest commit: 3c9a974

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@sw-internal/e2e-realtime-api Patch
@signalwire/realtime-api Patch
@sw-internal/stack-tests Patch
@signalwire/core Patch
@signalwire/js Patch
@signalwire/web-api Patch
@signalwire/webrtc Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@edolix edolix requested a review from iAmmar7 August 15, 2023 14:39
Copy link
Collaborator

@iAmmar7 iAmmar7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@edolix edolix merged commit bb50b2f into main Aug 15, 2023
@edolix edolix deleted the eg/close-event-fix branch August 15, 2023 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants