Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make context optional in Messaging send method #499

Merged
merged 3 commits into from
Apr 14, 2022
Merged

Make context optional in Messaging send method #499

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2013e31
make context optional in Messaging send
edolix Apr 13, 2022
c8936d7
changeset
edolix Apr 13, 2022
80e1477
remove default value for context
edolix Apr 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/thick-buses-sip.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
'@sw-internal/playground-realtime-api': patch
'@signalwire/realtime-api': patch
---

[internal] Make `context` optional in Messaging `send()` method.
1 change: 0 additions & 1 deletion internal/playground-realtime-api/src/messaging/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ async function run() {

try {
const response = await client.send({
context: 'office',
from: '+1xxx',
to: '+1yyy',
body: 'Hello World!',
Expand Down
2 changes: 1 addition & 1 deletion packages/realtime-api/src/messaging/Messaging.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import { messagingWorker } from './workers'
import { MessageContract, Message } from './Message'

interface MessagingSendParams {
context: string
context?: string
from: string
to: string
body?: string
Expand Down