Voice namespace #460
Merged
Voice namespace #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8f8b031 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
framini
force-pushed
the
fr/voice-namespace
branch
2 times, most recently
from
45b09d2 to
c902f23
Compare
framini
commented
Mar 25, 2022
| tag: this.__uuid, | ||
| devices: toInternalDevices(params.devices), | ||
| }, | ||
| }).catch((e) => { |
There was a problem hiding this comment.
These are needed so our users can try/catch the method. Otherwise the error will be marked as unhandled
| export const CallAPI = extendComponent< | ||
| CallConsumer, | ||
| Omit<VoiceCallMethods, 'dial' | 'hangup'> | ||
| >(CallConsumer, {}) |
There was a problem hiding this comment.
I left it like this just for the future and to follow the same pattern as other constructors since we'll likely add regular execute methods.
framini
force-pushed
the
fr/voice-namespace
branch
from
d0f2577 to
d426260
Compare
…he call has been answered/failed
… received the answered state
edolix
force-pushed
the
fr/voice-namespace
branch
from
d426260 to
8f8b031
Compare
|
Rebased |
edolix
approved these changes
Mar 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.