Automatic subscribe for RoomSession #435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 769c161 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
framini
commented
Feb 17, 2022
framini
changed the title
edolix
reviewed
Feb 24, 2022
| @@ -172,4 +172,24 @@ describe('RoomSession Object', () => { | |||
| }) | |||
| }) | |||
| }) | |||
|
|
|||
| describe.only('automatic subscribe', () => { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code in this changeset makes the call to
RoomSession.subscribe()optional. As of this PR the user will only have to attach the events they are interested and the SDK will take care of handling the underlying subscriptions to receive the events. TheVideoClientwas already auto-connecting and this PR finishes the job started in #411