Standardize method names #302
Conversation
🦋 Changeset detectedLatest commit: 14047b2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@danieleds Adding you as a reviewer to double check the docs are still ok. |
| * **room.ended**<br> | ||
| * **room.started**,<br> | ||
| * **room.updated**,<br> | ||
| * **room.ended**<br> | ||
| * Emitted when the room session is, respectively, started, updated, or ended. |
There was a problem hiding this comment.
@framini these eol spaces were needed for intellisense, which otherwise puts everything on the same line. For readme instead, we need the <br>
There was a problem hiding this comment.
all other eol spaces which are not preceded by a <br> are fine to be removed
There was a problem hiding this comment.
That's Prettier in action 🤔
| setMicrophoneVolume(params: { volume: number }): Rooms.SetInputVolumeMember | ||
|
|
||
| /** | ||
| * Sets the input level for the member. |
There was a problem hiding this comment.
can you add an example real quick? e.g.
Sets the input volume for the member (e.g., the microphone input level).
|
|
||
| /** | ||
| * Sets the speaker output level. | ||
| * Sets the output level. |
There was a problem hiding this comment.
same as above, this could be
Sets the output volume for the member (e.g., the speaker output level).
| }): Promise<void> | ||
|
|
||
| /** | ||
| * Sets the input level for a given member. |
There was a problem hiding this comment.
could you add the same change as above?
| setSpeakerVolume(params: { memberId: string; volume: number }): Promise<void> | ||
|
|
||
| /** | ||
| * Sets the output level. |
The code in this changeset includes
setInputVolumeandsetOutputVolumeas future replacements forsetMicrophoneVolumeandsetSpeakerVolumerespectively.