Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardise usage of internal and local events #298

Merged
merged 14 commits into from
Sep 20, 2021
Merged

Standardise usage of internal and local events #298

merged 14 commits into from
Sep 20, 2021

Conversation

framini
Copy link
Contributor

@framini framini commented Sep 16, 2021 •
edited
Loading

The code in this changeset includes:

  1. Improve how we handle transforms, cache and event registering in general by standardising the shape of the event (we're now using internalEvent everywhere)
  2. Added ability to register local transforms and remote transforms by extending applyEmitterTransforms. (I left a TODO as a comment: here)
  3. Add the concept of a "local" event to handle events that we generate and trigger (video.__local__.recording.start)

@changeset-bot
Copy link

changeset-bot bot commented Sep 16, 2021 •
edited
Loading

🦋 Changeset detected

Latest commit: 1549109

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@signalwire/core Patch
@signalwire/js Patch
@signalwire/react-native Patch
@signalwire/realtime-api Patch
@signalwire/web-api Patch
@signalwire/webrtc Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@framini framini changed the title WIP: Unify usage of internal events for everything WIP: Unify usage of internal events Sep 16, 2021
@framini framini changed the title WIP: Unify usage of internal events Standardise usage of internal and local events Sep 17, 2021
edolix
edolix reviewed Sep 17, 2021
View reviewed changes
Copy link
Contributor

@edolix edolix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Nice cleanup of our BaseComponent ❤️

packages/core/src/utils/index.ts Outdated Show resolved Hide resolved
.changeset/flat-rockets-draw.md Outdated Show resolved Hide resolved
packages/realtime-api/src/video/RoomSession.test.ts Show resolved Hide resolved
packages/core/src/BaseComponent.ts Outdated Show resolved Hide resolved
packages/core/src/BaseComponent.ts Show resolved Hide resolved
edolix
edolix approved these changes Sep 20, 2021
View reviewed changes
Copy link
Contributor

@edolix edolix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@edolix edolix merged commit 49b4aa9 into main Sep 20, 2021
@edolix edolix deleted the fr/int-emitter branch September 20, 2021 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edolix edolix edolix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@framini @edolix