Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Realtime-api SDK: Fix types export for module NodeNext #1024

Merged
merged 2 commits into from
Apr 22, 2024
Merged

Conversation

iAmmar7
Copy link
Collaborator

@iAmmar7 iAmmar7 commented Apr 16, 2024

Description

Based on this thread on the TypeScript repo: microsoft/TypeScript#52363

This PR explicitly mentions the types path in the package.json which allows developers to build their Node project using the NodeNext module in the tsconfig.

ref: #964

Type of change

  • Internal refactoring
  • Bug fix (bugfix - non-breaking)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Code snippets

In case of new feature or breaking changes, please include code snippets.

Copy link

changeset-bot bot commented Apr 16, 2024

🦋 Changeset detected

Latest commit: d769eda

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@signalwire/realtime-api Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@iAmmar7 iAmmar7 requested review from jpsantosbh and ayeminag April 16, 2024 16:21
@iAmmar7 iAmmar7 merged commit a0f8812 into main Apr 22, 2024
19 of 24 checks passed
@iAmmar7 iAmmar7 deleted the aa/fix-types branch April 22, 2024 12:02
iAmmar7 added a commit that referenced this pull request Apr 25, 2024
* Fix types export for module NodeNext

* include changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants