Exclude build-id links from rpm #773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstumpfx
approved these changes
Sep 23, 2021
|
Curious why the build ids collide, but if these aren't necessary and it works that seems good enough. |
|
I think that since the collector and signalfx-agent may contain the same ELF files, the same build-id symlinks are generated. But from what I understand, these symlinks are primarily for debugging, so excluding them shouldn't be an issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #767. Resolves installation conflicts for
/usr/lib/.build-idlinks if the signalfx-agent rpm is already installed.