[chore] Fix deprecation warning for multiline config source calls #5829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a deprecation for bare config source calls. `${source:value[?params]}` should be used instead of `$source:value[?params]`.
It's also applied to multiline config source calls. One-line format like `${source:value?param1=val1,param2=val2}` should be used instead of multiline calls with a bare reference to a config source like the following DEPRECATED call:
```
config_field: |
$source: value
param1: val1
param2: val2
```
However, the deprecation warning is broken. This change fixes that. So instead of
```
[WARNING] Config source expansion formatted as $uri:selector has been deprecated, use ${uri:selector[?params]} instead. Please replace $include: /Users/danoshin/Projects/otel-configs/memory-limiter.yaml
watch_files: true
with ${include: /Users/danoshin/Projects/otel-configs/memory-limiter.yaml
watch_files: true
} in your configuration
```
users will see
```
[WARNING] Calling config sources in multiline format is deprecated. Please convert the following call to the one-line format ${uri:selector?param1=value1,param2=value2}:
include: /Users/danoshin/Projects/otel-configs/memory-limiter.yaml
watch_files: true
```
One-line deprecation warnings stay as is.
dmitryax
force-pushed
the
fail-bare-env-vars
branch
from
4782476 to
b4de2b0
Compare
atoulme
approved these changes
Jan 21, 2025
jinja2
approved these changes
Jan 21, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a deprecation for bare config source calls.
${source:value[?params]}should be used instead of$source:value[?params].It's also applied to multiline config source calls. One-line format like
${source:value?param1=val1,param2=val2}should be used instead of multiline calls with a bare reference to a config source like the following DEPRECATED call:However, the deprecation warning is broken. This change fixes that. So instead of
users will see
One-line deprecation warnings stay as is.