[Tanzu Tile] Add host.name resource attribute #5810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinja2
approved these changes
Jan 17, 2025
pjanotti
approved these changes
Jan 17, 2025
| @@ -23,8 +23,11 @@ receivers: | |||
| <% end %> | |||
|
|
|||
| processors: | |||
| resourcedetection: | |||
There was a problem hiding this comment.
Can we somehow test this file so it doesn't get stale like it did here?
There was a problem hiding this comment.
There isn't a quick way to test this automatically. Running a BOSH deployment requires a lot of set up and dependency installs, so it'd be some amount of effort. This file doesn't get changed much and is tested directly with each Tanzu Tile release.
The change to the config here is a bug fix, it didn't actually go stale.
Edit: I can definitely see there being value in adding CI/CD testing for this, my main point is that it would be its own task to track, outside of the scope of this change.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The
host.nameresource attribute should come from the Tanzu environment, not the environment in which the collector itself is running.Note:
No changelog here because this won't have any impact until a new Tanzu Tile release is created.
Testing:
Tested on TAS 10.0 and TAS 6.0. Working as expected. The
host.nameis populated as the IP address of the BOSH director.