Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace logging exporter with debug exporter in configuration files and examples #3709

Closed
wants to merge 3 commits into from

Conversation

theletterf
Copy link
Contributor

Following the steps of open-telemetry/opentelemetry.io#3279. Solves #3708

Someone might want to also update the dependencies? I don't dare doing it. :-)

@theletterf theletterf requested a review from a team as a code owner September 29, 2023 08:22
@theletterf theletterf self-assigned this Sep 29, 2023
@theletterf theletterf requested review from a team as code owners September 29, 2023 08:22
@theletterf theletterf changed the title Theletterf switch from loggingexporter Replace logging exporter with debug exporter in configuration files and examples Sep 29, 2023
@theletterf theletterf added the documentation Improvements or additions to documentation label Sep 29, 2023
@rmfitzpatrick
Copy link
Contributor

In order for this to be valid we'd need to include the debug exporter in our distribution, which isn't the case atm.

Copy link
Contributor

@rmfitzpatrick rmfitzpatrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please ensure we've included this required component.

@theletterf
Copy link
Contributor Author

@rmfitzpatrick Not sure if doing this in the present PR or wait for a code PR.

@atoulme
Copy link
Contributor

atoulme commented Oct 3, 2023

Adding the new component warrants a separate PR, we will get to work on that soon as the logging exporter is marked deprecated.

@theletterf
Copy link
Contributor Author

Seems like we can proceed after #3735 (thanks, @rmfitzpatrick !)

How do I get rid of the test errors again? I want to get this right on my machine...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants