feat: enabling scriptedinputs receiver in components #3627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please add an integration test along with these changes. You can use |
internal/receiver/scriptedinputsreceiver/testdata/resource_logs/cpu.yaml
Outdated
Show resolved
Hide resolved
|
Please rebase. |
| @@ -0,0 +1,2 @@ | |||
| scripted_inputs/cpu: | |||
There was a problem hiding this comment.
believe this file can be deleted
weliasz
force-pushed
the
script_receiver_components
branch
from
5ff46f3 to
388f473
Compare
| @@ -96,6 +97,10 @@ func (c *Config) Validate() error { | |||
|
|
|||
| // Build will build a stdoutOperator. | |||
| func (c *Config) Build(logger *zap.SugaredLogger) (operator.Operator, error) { | |||
| if isContainer() { | |||
| return nil, fmt.Errorf("scriped inputs receiver must be run directly on host and is not supported in container") | |||
There was a problem hiding this comment.
Mind updating the readme?
rmfitzpatrick
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.