DNM: Allow systemd-only auto instrumentation #3489
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffreyc-splunk
force-pushed
the
systemd-auto-instrumentation
branch
from
6a04886 to
6660db1
Compare
aunshc
reviewed
Aug 14, 2023
| > 1. To prevent conflicts and duplicate traces/metrics, only one package should be installed on the target system. | ||
| > 2. The configuration files and the options defined within are only applicable for the respective package that is | ||
| > installed. For example, `/usr/lib/splunk-instrumentation/instrumentation.conf` is only applicable with | ||
| > `splunk-otel-auto-instrumentation`, and `` is only |
There was a problem hiding this comment.
Suggested change
| > `splunk-otel-auto-instrumentation`, and `` is only | |
| > `splunk-otel-auto-instrumentation`, and `00-splunk-otel-javaagent.conf` is only |
Should this be a reference to the systemd drop-in file?
There was a problem hiding this comment.
Good catch, I'll update it.
aunshc
reviewed
Aug 14, 2023
| ./packaging/00-splunk-otel-javaagent.conf) drop-in file defines the following environment variables to | ||
| enable the installed agent(s) to auto instrument supported Java applications running as `systemd` services: | ||
|
|
||
| - `JAVA_TOOL_OPTIONS=-javaagent:/usr/lib/splunk-instrumentation/splunk-otel-javaagent.jar` |
There was a problem hiding this comment.
Let's also add OTEL_EXPORTER_OTLP_ENDPOINT as a default option in the drop-in file too. Quick question: If there are specific options set from the installers (eg. deployment.environment) or profiling, would the relevant env variable be set here?
There was a problem hiding this comment.
We can add any environment variable to this file or in a separate drop-in file created by the installers.
jeffreyc-splunk
changed the title
|
Closing this in favor of #3506 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
splunk-otel-auto-instrumentationandlibsplunk.soas-is (moved code frominstrumentation/toinstrumentation/splunk-otel-auto-instrumentation/)splunk-otel-systemd-auto-instrumentationthat includes the java agent and a systemd drop-in file withJAVA_TOOL_OPTIONSTODO: Update installers to support the systemd package and configuration.