Remove handling of unsupported --mem-ballast-size-mib command line argument #2339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryax
changed the title
dmitryax
changed the title
|
Considering this hasn't worked for a bit it makes sense to remove as you have, but it could also be restored but no longer passed to the service w/ |
Yes, I understand that, but given that it has been broken for a while, I think it's safe to remove which has to be done anyway at some point I believe |
The argument was removed from the core collector in v0.36.0. We kept supporting it in our distro but the support is broken. We never remove that argument as we do for others and it's being passed to the core collector in https://github.com/signalfx/splunk-otel-collector/blob/main/cmd/otelcol/main.go#L105 where it fails with the following error: ``` 2022/12/08 16:25:34 main.go:106: application run finished with error: unknown flag: --mem-ballast-size-mib ``` So I don't think it makes sense to bring back the support of it
dmitryax
force-pushed
the
remove-mem-ballast-size-mib
branch
from
e69b188 to
8a22918
Compare
atoulme
approved these changes
Dec 9, 2022
|
I don't think there is a reason to keep and maintain an additional configuration option which is likely not being used given that there were no complaints since 0.36.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The argument was removed from the core collector in v0.36.0. We kept supporting it in our distro but the support is broken. We never remove that argument as we do for others and it's being passed to the core collector in https://github.com/signalfx/splunk-otel-collector/blob/main/cmd/otelcol/main.go#L105 where it fails with the following error:
So I don't think it makes sense to bring back support of it.