add initial discovery mode #2195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmfitzpatrick
commented
Oct 31, 2022
| @@ -166,7 +164,7 @@ func (d *discoveryReceiver) consumerLoop(loopStarted *sync.WaitGroup) { | |||
| func (d *discoveryReceiver) createAndSetReceiverCreator() error { | |||
| receiverCreatorFactory, receiverCreatorConfig, err := d.config.receiverCreatorFactoryAndConfig(d.endpointTracker.correlations) | |||
| if err != nil { | |||
| return nil | |||
| return err | |||
rmfitzpatrick
force-pushed
the
discoverymodeinitial
branch
from
a6573ef to
6ec382c
Compare
atoulme
approved these changes
Oct 31, 2022
rmfitzpatrick
force-pushed
the
discoverymodeinitial
branch
2 times, most recently
from
a8c6258 to
ce5a2b0
Compare
rmfitzpatrick
force-pushed
the
discoverymodeinitial
branch
from
ce5a2b0 to
2ddcf51
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes add new
--discoveryand--dry-runcmdline options to run a limited preflight collector service using any.discovery.yamlreceivers and observers from the config directory and embed them into an internal discovery receiver instance whose successful status logs lead to injecting the discovered receivers into a receiver creator for the final config. If--dry-runis set, then the final config will be written to stdout before exiting instead of running the service.Along with this new functionality, a new common internal discovery package is being added to avoid repeated logic in addition to new config server testutils collector container helpers to load the initial and effective configs.