Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the secret validation hook pod to use imagePullSecrets instead of possible non-existing serviceAccountName #888

Merged
merged 1 commit into from
Aug 15, 2023
Merged

Update the secret validation hook pod to use imagePullSecrets instead of possible non-existing serviceAccountName #888

merged 1 commit into from
Aug 15, 2023

Conversation

jvoravong
Copy link
Contributor

Issue: #780

Description:

  • The secret validation hook runs in the pre-install phase while the service account is made in the install phase. This can cause errors.

Testing:

  • Validated the secret validation hook pod works when pulling and using images from a private image registry.

@jvoravong
Update the secret validation hook pod to use imagePullSecrets instead…
9d0560c 
… of possible non-existing serviceAccountName
@jvoravong jvoravong requested review from a team as code owners August 15, 2023 22:49
@jvoravong jvoravong merged commit 9af77c1 into signalfx:main Aug 15, 2023
@jvoravong jvoravong deleted the gh-780 branch August 15, 2023 22:59
@jvoravong jvoravong mentioned this pull request Aug 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jinja2 jinja2 jinja2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jvoravong @jinja2