Apply agent resources to init containers #690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryax
force-pushed
the
set-resources-on0init-containers
branch
from
428c055 to
a6400d0
Compare
Azure Defender throws warnings expecting all containers to have resource limits specified, even on init containers. This change applies the same resources to init containers as allocated to the collector agent. The pod effective limits are not affected because init container limits don't adds up, highest value is applied instead.
dmitryax
force-pushed
the
set-resources-on0init-containers
branch
from
a6400d0 to
1c459d2
Compare
jvoravong
approved these changes
Mar 8, 2023
rmfitzpatrick
approved these changes
Mar 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Azure Defender throws warnings expecting all containers to have resource limits specified, even on init containers. This change applies the same resources to init containers as allocated to the collector agent. The pod effective limits are not affected because init container limits don't adds up, highest value is applied instead.