Migrate filelog operators to follow opentelemetry-log-collection v0.29.0 changes #436
Conversation
hvaghani221
changed the title
helm-charts/splunk-otel-collector/templates/config/_otel-agent.tpl
Outdated
Show resolved
Hide resolved
|
Did some dog food testing with these changes, functionality looked good. We will probably want to wait to merge this PR until Splunk Otel Collector v.049.0 is available. |
|
Please also add an entry for this PR to CHANGELOG.md. |
hvaghani221
changed the title
| attributes, or resource. Also they have updated/removed some of the operators. | ||
| If you are using `extraFileLogs` or `logsCollection.containers.extraOperators` config, | ||
| see [Upgrading Guideline](https://github.com/open-telemetry/opentelemetry-log-collection/blob/v0.29.0/CHANGELOG.md#upgrading-to-v0290) | ||
|
|
There was a problem hiding this comment.
A lot of this looks good, I'd suggest making these updates. We should also update the title of this PR to match this (include opentelemetry-log-collection v0.29.0).
- Migrate filelog operators to follow opentelemetry-log-collection v0.29.0 changes (Migrate filelog operators to follow opentelemetry-log-collection v0.29.0 changes #436)
- [BREAKING CHANGE] Several breaking changes were made that affect the
filelog, syslog, tcplog, udplog, and journald receivers. Any use of the
extraFileLogs
config,
logsCollection.containers.extraOperators
config, and affected receivers in a custom manner should be reviewed. See
upgrading guidelines
- [BREAKING CHANGE] Several breaking changes were made that affect the
There was a problem hiding this comment.
Today my team merged in the code for the splunk-otel-collector v0.49.0 release. Let's try to update this, I'll approve it, and I'll merge it.
hvaghani221
changed the title
CHANGELOG.md
Outdated
| @@ -4,6 +4,15 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/). | |||
|
|
|||
| ## Unreleased | |||
|
|
|||
| ### Changed | |||
|
|
|||
| - Migrate filelog operators to follow opentelemetry-log-collection v0.29.0 changes ([Migrate filelog operators to follow v0.29.0 changes #436](https://github.com/signalfx/splunk-otel-collector-chart/pull/436)) | |||
There was a problem hiding this comment.
nit to avoid repeat
| - Migrate filelog operators to follow opentelemetry-log-collection v0.29.0 changes ([Migrate filelog operators to follow v0.29.0 changes #436](https://github.com/signalfx/splunk-otel-collector-chart/pull/436)) | |
| - Migrate filelog operators to follow opentelemetry-log-collection v0.29.0 changes ([#436](https://github.com/signalfx/splunk-otel-collector-chart/pull/436)) |
| ### Changed | ||
|
|
||
| - Migrate filelog operators to follow opentelemetry-log-collection v0.29.0 changes ([Migrate filelog operators to follow v0.29.0 changes #436](https://github.com/signalfx/splunk-otel-collector-chart/pull/436)) | ||
| - [BREAKING CHANGE] Several breaking changes were made that affect the |
There was a problem hiding this comment.
It may be a good time to add an unreleased section to https://github.com/signalfx/splunk-otel-collector-chart/blob/main/UPGRADING.md so we can associate some updated examples with these changes.
There was a problem hiding this comment.
To move forward, I'd like to merge this PR the way it is. I'll open up a new PR today for updating UPGRADING.md.
I have followed the upgrading guideline of opentelemetry-log-collection (https://github.com/open-telemetry/opentelemetry-log-collection/releases/tag/v0.29.0 ) to migrate to the new field syntax.
I have
$$/$$.body,$$resources,$$attributestobody,resources,attributesaccordinglyregex_parserandjson_parseraccordinglyfile.*fields tolog.file.*