Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional native OTel logs collection #197

Merged
merged 5 commits into from
Sep 23, 2021
Merged

Conversation

dmitryax
Copy link
Contributor

We want to replace fluentd logs collection with native OTel logs collection. For now we adding this as an option. Later it will became default way to collect logs

The configuration for native logs collection mostly borrowed from https://github.com/splunk/sck-otel

@dmitryax dmitryax requested review from a team as code owners September 22, 2021 05:49
@dmitryax dmitryax force-pushed the native-otel-logs-collection branch 2 times, most recently from 4c1a0b4 to 629e62b Compare September 22, 2021 05:56
@emaderer
Copy link
Contributor

@dmitryax are there any differences in terms of what it will end up collecting if users enable native log collection?

@dmitryax
Copy link
Contributor Author

dmitryax commented Sep 22, 2021

@emaderer yes, native logs collection is missing the following attibutes: container.id and container.image.name. We will keep it optional until this issue is resolved and we can add those attributes back

@emaderer
Copy link
Contributor

@emaderer yes, native logs collection is missing the following attibutes: container.id and container.image.name. We will keep it optional until this issue is resolved and we can add those attributes back

I think that it might be a good idea to update the README file as part of this PR and mention the limitations of using the new option.

We want to replace fluentd logs collection with native OTel logs collection. For now we adding this as an option. Later it will become the default way to collect logs

The configuration for native logs collection mostly borrowed from https://github.com/splunk/sck-otel
@dmitryax dmitryax force-pushed the native-otel-logs-collection branch from 629e62b to 88ea6e8 Compare September 22, 2021 19:58
@dmitryax
Copy link
Contributor Author

@emaderer good point. I added a section to README, PTAL

- another limitation in readme
- move stream to log attribute from resource
- fix otel agent container path
@dmitryax dmitryax merged commit c343815 into main Sep 23, 2021
@dmitryax dmitryax deleted the native-otel-logs-collection branch September 23, 2021 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants