Template pod affinity settings from the correct value #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pod affinity settings were errornously reading from the tolerations value rather than the affinity value for both the collector and cluster receiver deployments. As a result, setting the affinity value would result in an affinity key being templated but with the contents of the tolerations value. This fix ensures the correct value is read, and also adds a leading dash to the template function to prevent an errornous newline from being added.
rmfitzpatrick
approved these changes
Jul 29, 2021
|
@KingJ thank you for fixing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pod affinity settings were erroneously reading from the tolerations value rather than the affinity value for both the collector and cluster receiver deployments. As a result, setting the affinity value would result in an affinity key being templated but with the contents of the tolerations value.
This fix ensures the correct value is read, and also adds a leading dash to the template function to prevent an erroneous newline from being added.