remove setting CRDs in test, use subchart

signalfx · Jan 10, 2025 · 7e467b4 · 7e467b4
1 parent df8b642
commit 7e467b4
Show file tree

Hide file tree

Showing 7 changed files with 0 additions and 64 deletions.
diff --git a/functional_tests/functional_test.go b/functional_tests/functional_test.go
@@ -172,41 +172,6 @@ func deployChartsAndApps(t *testing.T) {
 		}
 	}
 
-	// deploy the operator CRDs
-	stream, err = os.ReadFile(filepath.Join(testDir, manifestsDir, "operator_crds.yaml"))
-	require.NoError(t, err)
-
-	for _, resourceYAML := range strings.Split(string(stream), "---") {
-		if len(resourceYAML) == 0 {
-			continue
-		}
-
-		obj, groupVersionKind, err := decode(
-			[]byte(resourceYAML),
-			nil,
-			nil)
-		require.NoError(t, err)
-		if groupVersionKind.Group == "apiextensions.k8s.io" &&
-			groupVersionKind.Version == "v1" &&
-			groupVersionKind.Kind == "CustomResourceDefinition" {
-			crd := obj.(*appextensionsv1.CustomResourceDefinition)
-			apiExtensions := extensionsClient.ApiextensionsV1().CustomResourceDefinitions()
-			crd, err := apiExtensions.Create(context.Background(), crd, metav1.CreateOptions{})
-			require.NoError(t, err)
-			t.Logf("Deployed CRD %s", crd.Name)
-			for _, version := range crd.Spec.Versions {
-				sch.AddKnownTypeWithName(
-					schema.GroupVersionKind{
-						Group:   crd.Spec.Group,
-						Version: version.Name,
-						Kind:    crd.Spec.Names.Kind,
-					},
-					&unstructured.Unstructured{},
-				)
-			}
-		}
-	}
-
 	codecs := serializer.NewCodecFactory(sch)
 	crdDecode := codecs.UniversalDeserializer().Decode
 	// Prometheus pod monitor
@@ -536,29 +501,6 @@ func teardown(t *testing.T) {
 		}
 	}
 
-	crdstream, err = os.ReadFile(filepath.Join(testDir, manifestsDir, "operator_crds.yaml"))
-	require.NoError(t, err)
-	for _, resourceYAML := range strings.Split(string(crdstream), "---") {
-		if len(resourceYAML) == 0 {
-			continue
-		}
-
-		obj, groupVersionKind, err := decode(
-			[]byte(resourceYAML),
-			nil,
-			nil)
-		require.NoError(t, err)
-		if groupVersionKind.Group == "apiextensions.k8s.io" &&
-			groupVersionKind.Version == "v1" &&
-			groupVersionKind.Kind == "CustomResourceDefinition" {
-			crd := obj.(*appextensionsv1.CustomResourceDefinition)
-			apiExtensions := extensionsClient.ApiextensionsV1().CustomResourceDefinitions()
-			_ = apiExtensions.Delete(context.Background(), crd.Name, metav1.DeleteOptions{
-				GracePeriodSeconds: &waitTime,
-			})
-		}
-	}
-
 	for _, nm := range namespaces {
 		nmClient := client.CoreV1().Namespaces()
 		_ = nmClient.Delete(context.Background(), nm.Name, metav1.DeleteOptions{

diff --git a/functional_tests/testdata/values/aks_test_values.yaml.tmpl b/functional_tests/testdata/values/aks_test_values.yaml.tmpl
@@ -70,8 +70,6 @@ livenessProbe:
 
 operator:
   enabled: true
-  crds:
-    create: false
   admissionWebhooks:
     certManager:
       enabled: false

diff --git a/functional_tests/testdata/values/autopilot_test_values.yaml.tmpl b/functional_tests/testdata/values/autopilot_test_values.yaml.tmpl
@@ -62,8 +62,6 @@ distribution: gke/autopilot
 
 operator:
   enabled: true
-  crds:
-    create: false
   admissionWebhooks:
     certManager:
       enabled: false

diff --git a/functional_tests/testdata/values/test_values.yaml.tmpl b/functional_tests/testdata/values/test_values.yaml.tmpl
@@ -71,8 +71,6 @@ extraAttributes:
 environment: dev
 operator:
   enabled: true
-  crds:
-    create: false
 targetAllocator:
   enabled: true
 

diff --git a/...ds/opentelemetry.io_instrumentations.yaml → ...ds/opentelemetry.io_instrumentations.yaml b/...ds/opentelemetry.io_instrumentations.yaml → ...ds/opentelemetry.io_instrumentations.yaml
diff --git a/...r-crds/opentelemetry.io_opampbridges.yaml → ...s/crds/opentelemetry.io_opampbridges.yaml b/...r-crds/opentelemetry.io_opampbridges.yaml → ...s/crds/opentelemetry.io_opampbridges.yaml
diff --git a/...telemetry.io_opentelemetrycollectors.yaml → ...telemetry.io_opentelemetrycollectors.yaml b/...telemetry.io_opentelemetrycollectors.yaml → ...telemetry.io_opentelemetrycollectors.yaml