This repository has been archived by the owner on Oct 23, 2024. It is now read-only.
Make vmem monitor default on Linux #1143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
keitwb
commented
Jan 15, 2020
keitwb
commented
- Remove beta warning for Linux
- Remove plugin dimension
- Clean up memory monitor
keitwb
force-pushed
the
vmem-default
branch
4 times, most recently
from
114e107 to
45e917d
Compare
bjsignalfx
reviewed
Jan 16, 2020
| "github.com/signalfx/golib/v3/datapoint" | ||
| ) | ||
|
|
||
| func (m *Monitor) makeMemoryDatapoints(memInfo *mem.VirtualMemoryStat, dimensions map[string]string) []*datapoint.Datapoint { |
There was a problem hiding this comment.
Wait, how is this magic happening? Same function signature in the same package. How is this not a compile error?
There was a problem hiding this comment.
See https://dave.cheney.net/2013/10/12/how-to-use-conditional-compilation-with-the-go-build-tool, esp. the section of "File Suffixes".
- Remove beta warning for Linux - Remove plugin dimension - Clean up memory monitor - Also making retry on EBADF more robust against wrapped exceptions
keitwb
pushed a commit
that referenced
this pull request
Jan 17, 2020
- Remove beta warning for Linux - Remove plugin dimension - Clean up memory monitor - Also making retry on EBADF more robust against wrapped exceptions
keitwb
pushed a commit
that referenced
this pull request
Jan 21, 2020
- Remove beta warning for Linux - Remove plugin dimension - Clean up memory monitor - Also making retry on EBADF more robust against wrapped exceptions
keitwb
pushed a commit
that referenced
this pull request
Jan 22, 2020
- Remove beta warning for Linux - Remove plugin dimension - Clean up memory monitor - Also making retry on EBADF more robust against wrapped exceptions
keitwb
pushed a commit
that referenced
this pull request
Jan 22, 2020
- Remove beta warning for Linux - Remove plugin dimension - Clean up memory monitor - Also making retry on EBADF more robust against wrapped exceptions
keitwb
pushed a commit
that referenced
this pull request
Jan 28, 2020
- Remove beta warning for Linux - Remove plugin dimension - Clean up memory monitor - Also making retry on EBADF more robust against wrapped exceptions
keitwb
pushed a commit
that referenced
this pull request
Jan 29, 2020
- Remove beta warning for Linux - Remove plugin dimension - Clean up memory monitor - Also making retry on EBADF more robust against wrapped exceptions
keitwb
pushed a commit
that referenced
this pull request
Jan 30, 2020
- Remove beta warning for Linux - Remove plugin dimension - Clean up memory monitor - Also making retry on EBADF more robust against wrapped exceptions
keitwb
pushed a commit
that referenced
this pull request
Feb 21, 2020
- Remove beta warning for Linux - Remove plugin dimension - Clean up memory monitor - Also making retry on EBADF more robust against wrapped exceptions
keitwb
pushed a commit
that referenced
this pull request
Feb 24, 2020
- Remove beta warning for Linux - Remove plugin dimension - Clean up memory monitor - Also making retry on EBADF more robust against wrapped exceptions
keitwb
pushed a commit
that referenced
this pull request
Feb 25, 2020
- Remove beta warning for Linux - Remove plugin dimension - Clean up memory monitor - Also making retry on EBADF more robust against wrapped exceptions
keitwb
pushed a commit
that referenced
this pull request
Feb 25, 2020
- Remove beta warning for Linux - Remove plugin dimension - Clean up memory monitor - Also making retry on EBADF more robust against wrapped exceptions
keitwb
pushed a commit
that referenced
this pull request
Feb 28, 2020
- Remove beta warning for Linux - Remove plugin dimension - Clean up memory monitor - Also making retry on EBADF more robust against wrapped exceptions
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.