Fix 'secondSubtitle' KeyError for some playlists #399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sigma67
requested changes
Jun 19, 2023
| playlist['duration'] = None if not has_duration else second_subtitle_runs[has_views + has_duration]['text'] | ||
| song_count = second_subtitle_runs[has_views + 0]['text'].split(" ") | ||
| song_count = to_int(song_count[0]) if len(song_count) > 1 else 0 | ||
| if 'runs' in header['secondSubtitle']: |
There was a problem hiding this comment.
That will lead to missing views and duration keys. Can you add default value None for these?
There was a problem hiding this comment.
Good catch! Added the default values :-)
sigma67
added a commit
that referenced
this pull request
Jul 2, 2023
sigma67
pushed a commit
that referenced
this pull request
Jul 14, 2024
* Fix 'secondSubtitle' KeyError for some playlists * Feedback.
sigma67
added a commit
that referenced
this pull request
Jul 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes parsing of playlists that do not have a
['secondSubtitle']['runs']property. An example of this play list is https://music.youtube.com/playlist?list=RDATgXd-