get_artist: Don't fail on channels with only one category of content #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current check is meant to detect channels with only video content, but it also hits small bands that for example have only released singles so far. An example for this is "UC1uK8RT3m4nNpXmOSsFsZeg". Since failing is not really helpful anyway (for example in audiotube, it could still play only the sound of a channel that contains only videos), I propose to remove the check altogether.
|
This exception was introduced in #181. It seems reasonable in my opinion to filter out invalid channels with a proper exception. There should be a better way to filter these though than just checking for the length. I agree that the current solution is far from ideal since it affects small artists. |
sigma67
pushed a commit
that referenced
this pull request
Apr 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current check is meant to detect channels with only video content,
but it also hits small bands that for example have only released singles
so far. An example for this is "UC1uK8RT3m4nNpXmOSsFsZeg".
Since failing is not really helpful anyway (for example audiotub could still play only the sound of a channel that contains only videos),
I propose to remove the check altogether.