Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get_artist_albums: add singles filter and sort #441

Closed
sigma67 opened this issue Sep 25, 2023 · 1 comment
Closed

get_artist_albums: add singles filter and sort #441

sigma67 opened this issue Sep 25, 2023 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@sigma67
Copy link
Owner

sigma67 commented Sep 25, 2023

The artist albums page has a new look: https://music.youtube.com/browse/MPADUC-CcyIM_seGnGL5-2Fsppow

get_artist_albums should support the new filters through parameters consistent with the rest of the API. Contributions are welcome.
@sigma67 sigma67 added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Sep 25, 2023
@sigma67 sigma67 mentioned this issue Sep 25, 2023
Closed
@sigma67
Copy link
Owner Author

sigma67 commented Oct 3, 2023

The filters are written using continuations.

Need two function parameters filter = "singles"/"albums" and sort = "default"/"recency"/"popularity"/"alphabetical"

Based on the function parameters given, grab the relevant continuations from header.musicSideAlignedItemRender.startItems (for filters) or from header.musicSideAlignedItemRender.endItems (for sort) and replace the returned response with the continuation response before parsing and returning to the user.

sigma67 added a commit that referenced this issue Jan 10, 2024
@sigma67
get_artist_albums: support continuations (#441)
f8425df
sigma67 added a commit that referenced this issue Jan 10, 2024
@sigma67
get_artist_albums: add order param (#441)
caa27a9
sigma67 added a commit that referenced this issue Jan 10, 2024
@sigma67
get_artist_albums: support continuations (#441)
f2be194
sigma67 added a commit that referenced this issue Jan 10, 2024
@sigma67
get_artist_albums: add order param (#441)
e864a6b
@sigma67 sigma67 closed this as completed Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sigma67