Fixing leader election and RBAC permissions #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nandajavarma
approved these changes
Sep 17, 2021
There was a problem hiding this comment.
Really good catch @nutellinoit ! I was shortsighted to have hacked it with the update of the configmaps across all namespaces. LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi team, we found a bug on the nginx leader election.
The main issue can be found here: https://github.com/kubernetes/ingress-nginx/blame/5c6a28464bad138ff84f1d9a3414963d4b7c236f/internal/ingress/controller/nginx.go#L259
They silently changed the logic on how the nginx ingress controller manages the leader election.
I reverted the role permission that grants the update to all the namespace confimaps and changed all the election-id accordingly